judsonupchurch/nanoMODBUS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Wswitch-enum and Wcast-qual compiler warnings

Browse Source 
The function nmbs_strerror does not handle the error code
NMBS_ERROR_INVALID_UNIT_ID inside the switch statement, which triggers
the GCC/Clang Wswitch-enum warning. Adding a new case inside the switch
statement solves this warning.

There is a cast from a const void pointer to an uint8_t pointer inside
the function nmbs_send_raw_pdu, which triggers the GCC/Clang Wcast-qual
warning. Adding the missing const qualifier solves this warning.
This commit is contained in:
Antonio Aguilera 2022-12-27 20:42:36 +01:00
parent b4172c8fef
commit fa02201710
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nanomodbus.c
View File

@ -1283,8 +1283,8 @@ nmbs_error nmbs_send_raw_pdu(nmbs_t* nmbs, uint8_t fc, const void* data, uint16_
DEBUG("raw "); DEBUG("raw ");
for (uint16_t i = 0; i < data_len; i++) { for (uint16_t i = 0; i < data_len; i++) {
put_1(nmbs, ((uint8_t*) (data))[i]); put_1(nmbs, ((const uint8_t*) (data))[i]);
DEBUG("%d ", ((uint8_t*) (data))[i]); DEBUG("%d ", ((const uint8_t*) (data))[i]);
} }
return send_msg(nmbs); return send_msg(nmbs);
@ -1315,6 +1315,9 @@ nmbs_error nmbs_receive_raw_pdu_response(nmbs_t* nmbs, void* data_out, uint16_t
#ifndef NMBS_STRERROR_DISABLED #ifndef NMBS_STRERROR_DISABLED
const char* nmbs_strerror(nmbs_error error) { const char* nmbs_strerror(nmbs_error error) {
switch (error) { switch (error) {
case NMBS_ERROR_INVALID_UNIT_ID:
return "invalid unit ID received";
case NMBS_ERROR_INVALID_TCP_MBAP: case NMBS_ERROR_INVALID_TCP_MBAP:
return "invalid TCP MBAP received"; return "invalid TCP MBAP received";