judsonupchurch/nanoMODBUS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Clang static analyser nit: zero out nmbs_bitfield structs.

Browse Source
This commit is contained in:
Jan Weiß 2023-04-04 15:53:14 +02:00
parent 920d25858d
commit f7dfbd94ab
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/arduino/client-rtu/client-rtu.ino
View File

@ -57,7 +57,7 @@ void loop() {
nmbs_set_destination_rtu_address(&nmbs, RTU_SERVER_ADDRESS); nmbs_set_destination_rtu_address(&nmbs, RTU_SERVER_ADDRESS);
// Write 2 coils from address 64 // Write 2 coils from address 64
nmbs_bitfield coils; nmbs_bitfield coils = {0};
nmbs_bitfield_write(coils, 0, 1); nmbs_bitfield_write(coils, 0, 1);
nmbs_bitfield_write(coils, 1, 1); nmbs_bitfield_write(coils, 1, 1);
err = nmbs_write_multiple_coils(&nmbs, 64, 2, coils); err = nmbs_write_multiple_coils(&nmbs, 64, 2, coils);

2
examples/linux/client-tcp.c
View File

@ -45,7 +45,7 @@ int main(int argc, char* argv[]) {
nmbs_set_read_timeout(&nmbs, 1000); nmbs_set_read_timeout(&nmbs, 1000);
// Write 2 coils from address 64 // Write 2 coils from address 64
nmbs_bitfield coils; nmbs_bitfield coils = {0};
nmbs_bitfield_write(coils, 0, 1); nmbs_bitfield_write(coils, 0, 1);
nmbs_bitfield_write(coils, 1, 1); nmbs_bitfield_write(coils, 1, 1);
err = nmbs_write_multiple_coils(&nmbs, 64, 2, coils); err = nmbs_write_multiple_coils(&nmbs, 64, 2, coils);

2
nanomodbus.c
View File

@ -669,7 +669,7 @@ static nmbs_error handle_write_multiple_coils(nmbs_t* nmbs) {
if (err != NMBS_ERROR_NONE) if (err != NMBS_ERROR_NONE)
return err; return err;
nmbs_bitfield coils; nmbs_bitfield coils = {0};
for (int i = 0; i < coils_bytes; i++) { for (int i = 0; i < coils_bytes; i++) {
coils[i] = get_1(nmbs); coils[i] = get_1(nmbs);
NMBS_DEBUG_PRINT("%d ", coils[i]); NMBS_DEBUG_PRINT("%d ", coils[i]);

4
tests/nanomodbus_tests.c
View File

@ -235,7 +235,7 @@ void test_fc1(nmbs_transport transport) {
expect(nmbs_read_coils(&CLIENT, 3, 1, NULL) == NMBS_EXCEPTION_ILLEGAL_DATA_VALUE); expect(nmbs_read_coils(&CLIENT, 3, 1, NULL) == NMBS_EXCEPTION_ILLEGAL_DATA_VALUE);
should("read with no error"); should("read with no error");
nmbs_bitfield bf; nmbs_bitfield bf = {0};
check(nmbs_read_coils(&CLIENT, 10, 3, bf)); check(nmbs_read_coils(&CLIENT, 10, 3, bf));
expect(nmbs_bitfield_read(bf, 0) == 1); expect(nmbs_bitfield_read(bf, 0) == 1);
expect(nmbs_bitfield_read(bf, 1) == 0); expect(nmbs_bitfield_read(bf, 1) == 0);
@ -302,7 +302,7 @@ void test_fc2(nmbs_transport transport) {
expect(nmbs_read_discrete_inputs(&CLIENT, 3, 1, NULL) == NMBS_EXCEPTION_ILLEGAL_DATA_VALUE); expect(nmbs_read_discrete_inputs(&CLIENT, 3, 1, NULL) == NMBS_EXCEPTION_ILLEGAL_DATA_VALUE);
should("read with no error"); should("read with no error");
nmbs_bitfield bf; nmbs_bitfield bf = {0};
check(nmbs_read_discrete_inputs(&CLIENT, 10, 3, bf)); check(nmbs_read_discrete_inputs(&CLIENT, 10, 3, bf));
expect(nmbs_bitfield_read(bf, 0) == 1); expect(nmbs_bitfield_read(bf, 0) == 1);
expect(nmbs_bitfield_read(bf, 1) == 0); expect(nmbs_bitfield_read(bf, 1) == 0);